Skip to content

Conversation

@MiriamAparicio
Copy link
Contributor

@MiriamAparicio MiriamAparicio commented Feb 6, 2025

Closes https://github.com/elastic/prodfiler/issues/4386

Summary

The flyout for the root block always contains the hint "Missing symbols error" because there are no symbols for the root block. We should not show it here.

What was done

Added a condition to not render the callout when frameType is root

Before

image

After

Waiting for this PR to be merged for the condition to work

@MiriamAparicio MiriamAparicio added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.1.0 labels Feb 6, 2025
@MiriamAparicio MiriamAparicio requested a review from a team as a code owner February 6, 2025 11:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@MiriamAparicio MiriamAparicio marked this pull request as draft February 6, 2025 11:19
@MiriamAparicio MiriamAparicio marked this pull request as ready for review February 6, 2025 11:59
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 406.9KB 406.9KB +22.0B

History

Copy link
Contributor

@miloszmarcinkowski miloszmarcinkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiriamAparicio MiriamAparicio merged commit 9e65d7a into elastic:main Feb 8, 2025
9 checks passed
@MiriamAparicio MiriamAparicio deleted the 4386-remove-callout-when-root-block branch February 8, 2025 08:31
cauemarcondes pushed a commit to cauemarcondes/kibana that referenced this pull request May 2, 2025
…pe is root (elastic#209978)

Closes elastic/prodfiler#4386

### Summary

The flyout for the root block always contains the hint "Missing symbols
error" because there are no symbols for the root block. We should not
show it here.

### What was done

Added a condition to not render the callout when frameType is root

Before

![image](https://github.com/user-attachments/assets/4856bf40-6753-46bd-a20d-74eebf27533f)

After

Waiting for [this
PR](elastic/elasticsearch#119115) to be merged
for the condition to work

(cherry picked from commit 9e65d7a)
@cauemarcondes
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

cauemarcondes added a commit that referenced this pull request May 8, 2025
…rame type is root (#209978) (#219964)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ObsUX][Profiling] Don't render missing symbols callout when frame
type is root (#209978)](#209978)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Miriam","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-08T08:31:25Z","message":"[ObsUX][Profiling]
Don't render missing symbols callout when frame type is root
(#209978)\n\nCloses
https://github.com/elastic/prodfiler/issues/4386\r\n\r\n###
Summary\r\n\r\nThe flyout for the root block always contains the hint
\"Missing symbols\r\nerror\" because there are no symbols for the root
block. We should not\r\nshow it here.\r\n\r\n### What was
done\r\n\r\nAdded a condition to not render the callout when frameType
is
root\r\n\r\nBefore\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/4856bf40-6753-46bd-a20d-74eebf27533f)\r\n\r\nAfter\r\n\r\nWaiting
for [this\r\nPR](elastic/elasticsearch#119115)
to be merged\r\nfor the condition to
work","sha":"9e65d7a18398877f2721b9b86c69e5fd205e190b","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:skip","Team:obs-ux-infra_services","v9.1.0"],"title":"[ObsUX][Profiling]
Don't render missing symbols callout when frame type is
root","number":209978,"url":"https://github.com/elastic/kibana/pull/209978","mergeCommit":{"message":"[ObsUX][Profiling]
Don't render missing symbols callout when frame type is root
(#209978)\n\nCloses
https://github.com/elastic/prodfiler/issues/4386\r\n\r\n###
Summary\r\n\r\nThe flyout for the root block always contains the hint
\"Missing symbols\r\nerror\" because there are no symbols for the root
block. We should not\r\nshow it here.\r\n\r\n### What was
done\r\n\r\nAdded a condition to not render the callout when frameType
is
root\r\n\r\nBefore\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/4856bf40-6753-46bd-a20d-74eebf27533f)\r\n\r\nAfter\r\n\r\nWaiting
for [this\r\nPR](elastic/elasticsearch#119115)
to be merged\r\nfor the condition to
work","sha":"9e65d7a18398877f2721b9b86c69e5fd205e190b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209978","number":209978,"mergeCommit":{"message":"[ObsUX][Profiling]
Don't render missing symbols callout when frame type is root
(#209978)\n\nCloses
https://github.com/elastic/prodfiler/issues/4386\r\n\r\n###
Summary\r\n\r\nThe flyout for the root block always contains the hint
\"Missing symbols\r\nerror\" because there are no symbols for the root
block. We should not\r\nshow it here.\r\n\r\n### What was
done\r\n\r\nAdded a condition to not render the callout when frameType
is
root\r\n\r\nBefore\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/4856bf40-6753-46bd-a20d-74eebf27533f)\r\n\r\nAfter\r\n\r\nWaiting
for [this\r\nPR](elastic/elasticsearch#119115)
to be merged\r\nfor the condition to
work","sha":"9e65d7a18398877f2721b9b86c69e5fd205e190b"}}]}] BACKPORT-->

Co-authored-by: Miriam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants